Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: modify detach timeout to match attach timeout #84321

Merged
merged 1 commit into from Oct 25, 2019
Merged

CSI: modify detach timeout to match attach timeout #84321

merged 1 commit into from Oct 25, 2019

Conversation

cduchesne
Copy link

@cduchesne cduchesne commented Oct 25, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
This makes it so detach timeout matches that of attach timeout.

This was discovered in #84169 and alleviates the following challenge:

  • if the attach-detach-reconcile-sync isn't disabled, it is possible to get enough volumeattachments in cluster, that it becomes impossible to detach volumes

#79529 changed csiTimeout from 15 seconds to 2 minutes, but missed making the same change for detach. Not all detach operations can complete in under 10 seconds, especially so if there is any api congestion.

When the api is throttling the attach-detach controller, volume attachments are given 2 minutes, and detachments only 10 seconds, therefore it's possible to never get a detach to succeed.

Which issue(s) this PR fixes:
Fixes #

Does this PR introduce a user-facing change?:

CSI detach timeout increased from 10 seconds to 2 minutes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Welcome @cduchesne!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @cduchesne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cduchesne
Copy link
Author

cc @saad-ali @msau42

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2019
@alejandrox1
Copy link
Contributor

/ok-to-test
/priority important-soon
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 25, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 25, 2019
@alejandrox1
Copy link
Contributor

/assign @jsafrane
ptal

@cduchesne
Copy link
Author

/retest

Sent with GitHawk

@cduchesne
Copy link
Author

/retest

@jsafrane
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cduchesne, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@cduchesne
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit cb0f80e into kubernetes:master Oct 25, 2019
This was referenced Oct 25, 2019
Merged
Merged
Merged
Closed
@cduchesne cduchesne deleted the csi-detach-timeout branch October 25, 2019 18:17
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2019
@k8s-ci-robot
Merge pull request #84375 from cduchesne/automated-cherry-pick-of-#84…
c3d9a5d 
…321-upstream-release-1.15

Automated cherry pick of #84321: modify detach timeout to be csiTimeout
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2019
@k8s-ci-robot
Merge pull request #84376 from cduchesne/automated-cherry-pick-of-#84…
13b46eb 
…321-upstream-release-1.14

Automated cherry pick of #84321: modify detach timeout to be csiTimeout
k8s-ci-robot added a commit that referenced this pull request Oct 29, 2019
@k8s-ci-robot
Merge pull request #84374 from cduchesne/automated-cherry-pick-of-#84…
1d36d8e 
…321-upstream-release-1.16

Automated cherry pick of #84321: modify detach timeout to be csiTimeout
@msau42 msau42 mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cduchesne @k8s-ci-robot @alejandrox1 @jsafrane